Chromium Code Reviews| Index: ui/views/bubble/bubble_delegate_unittest.cc |
| diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc |
| index 92201c0882a308cb08bee89482943f5a95868851..66050e2f757cdec384ab142fa52957a5f0912359 100644 |
| --- a/ui/views/bubble/bubble_delegate_unittest.cc |
| +++ b/ui/views/bubble/bubble_delegate_unittest.cc |
| @@ -15,6 +15,10 @@ |
| #include "ui/views/widget/widget.h" |
| #include "ui/views/widget/widget_observer.h" |
| +#if defined(OS_MACOSX) |
| +#include "ui/base/test/scoped_fake_nswindow_focus.h" |
| +#endif |
| + |
| namespace views { |
| namespace { |
| @@ -66,6 +70,10 @@ class BubbleDelegateTest : public ViewsTestBase { |
| } |
| private: |
| +#if defined(OS_MACOSX) |
| + ui::test::ScopedFakeNSWindowFocus fake_focus; |
| +#endif |
| + |
| DISALLOW_COPY_AND_ASSIGN(BubbleDelegateTest); |
| }; |
| @@ -278,6 +286,19 @@ TEST_F(BubbleDelegateTest, CloseReasons) { |
| bubble_delegate->set_close_on_deactivate(true); |
| Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate); |
| bubble_widget->Show(); |
| + EXPECT_FALSE(anchor_widget->IsVisible()); |
| +#if !defined(USE_AURA) |
| + // Bubbles are top-level which, on Aura, causes the parent->child |
|
tapted
2016/03/03 08:08:50
nit: re-wrap comment
Patti Lor
2016/03/03 23:24:32
Done.
|
| + // relationship to be managed by wm::TransientWindowManager |
| + // rather than the ui::Layer hierarchy. TransientWindowManager |
| + // currently permits a child to be shown when its parent is hidden, |
| + // but it shouldn't. This is http://crbug.com/590957. |
| + EXPECT_FALSE(bubble_widget->IsVisible()); |
| + anchor_widget->Show(); |
| + bubble_widget->Activate(); |
| +#endif |
| + EXPECT_TRUE(bubble_widget->IsVisible()); |
| + EXPECT_TRUE(bubble_widget->IsActive()); |
| anchor_widget->Activate(); |
| EXPECT_TRUE(bubble_widget->IsClosed()); |
| EXPECT_EQ(BubbleDelegateView::CloseReason::DEACTIVATION, |