Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: content/browser/media/cdm_service_impl_unittest.cc

Issue 1637083002: Add CdmService to keep track of CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + add default copy constructor Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/cdm_service_impl.cc ('k') | content/common/media/cdm_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/cdm_service_impl_unittest.cc
diff --git a/content/browser/media/cdm_service_impl_unittest.cc b/content/browser/media/cdm_service_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0d336a4a7fd2ba8ca4d634e3bd7a694dd5b94911
--- /dev/null
+++ b/content/browser/media/cdm_service_impl_unittest.cc
@@ -0,0 +1,105 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/media/cdm_service_impl.h"
+
+#include <algorithm>
+#include <string>
+#include <vector>
+
+#include "base/base_paths.h"
+#include "base/files/file_path.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/version.h"
+#include "content/public/common/cdm_info.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+
+const char kTestKeySystemType[] = "test";
+const char kTestPath[] = "/aa/bb";
+const char kVersion1[] = "1.1.1.1";
+const char kVersion2[] = "1.1.1.2";
+const char kTestCodecs[] = "vp9,mp4";
+const char kCodecDelimiter[] = ",";
+
+// For simplicity and to make failures easier to diagnose, this test uses
+// std::string instead of base::FilePath and std::vector<std::string>.
+class CdmServiceImplTest : public testing::Test {
+ public:
+ CdmServiceImplTest() {}
+ ~CdmServiceImplTest() override {}
+
+ protected:
+ void Register(const std::string& type,
+ const std::string& version,
+ const std::string& path,
+ const std::string& supported_codecs) {
+ const std::vector<std::string> codecs =
+ base::SplitString(supported_codecs, kCodecDelimiter,
+ base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
+ cdm_service_.RegisterCdm(CdmInfo(type, base::Version(version),
+ base::FilePath::FromUTF8Unsafe(path),
+ codecs));
+ }
+
+ bool IsRegistered(const std::string& type, const std::string& version) {
+ for (const auto& cdm : cdm_service_.GetAllRegisteredCdms()) {
+ if (cdm.type == type && cdm.version.GetString() == version)
+ return true;
+ }
+ return false;
+ }
+
+ std::vector<std::string> GetVersions(const std::string& type) {
+ std::vector<std::string> versions;
+ for (const auto& cdm : cdm_service_.GetAllRegisteredCdms()) {
+ if (cdm.type == type)
+ versions.push_back(cdm.version.GetString());
+ }
+ return versions;
+ }
+
+ private:
+ CdmServiceImpl cdm_service_;
+};
+
+// Note that KeySystemService is a singleton, and thus the actions of
+// one test impact other tests. So each test defines a different key system
+// name to avoid conflicts.
+
+TEST_F(CdmServiceImplTest, Register) {
+ Register(kTestKeySystemType, kVersion1, kTestPath, kTestCodecs);
+ EXPECT_TRUE(IsRegistered(kTestKeySystemType, kVersion1));
+}
+
+TEST_F(CdmServiceImplTest, ReRegister) {
+ Register(kTestKeySystemType, kVersion1, "/bb/cc", "unknown");
+ EXPECT_TRUE(IsRegistered(kTestKeySystemType, kVersion1));
+
+ // Now register same key system with different values.
+ Register(kTestKeySystemType, kVersion1, kTestPath, kTestCodecs);
+ EXPECT_TRUE(IsRegistered(kTestKeySystemType, kVersion1));
+}
+
+TEST_F(CdmServiceImplTest, MultipleVersions) {
+ Register(kTestKeySystemType, kVersion1, kTestPath, kTestCodecs);
+ Register(kTestKeySystemType, kVersion2, "/bb/cc", "unknown");
+ EXPECT_TRUE(IsRegistered(kTestKeySystemType, kVersion1));
+ EXPECT_TRUE(IsRegistered(kTestKeySystemType, kVersion2));
+}
+
+TEST_F(CdmServiceImplTest, NewVersionInsertedFirst) {
+ Register(kTestKeySystemType, kVersion1, kTestPath, kTestCodecs);
+ Register(kTestKeySystemType, kVersion2, "/bb/cc", "unknown");
+
+ const std::vector<std::string> versions = GetVersions(kTestKeySystemType);
+ EXPECT_EQ(2u, versions.size());
+ EXPECT_EQ(kVersion2, versions[0]);
+ EXPECT_EQ(kVersion1, versions[1]);
+}
+
+} // namespace content
« no previous file with comments | « content/browser/media/cdm_service_impl.cc ('k') | content/common/media/cdm_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698