Add CdmService to keep track of CDMs

content/browser/media/cdm_service_impl_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <algorithm>
+#include <string>
+#include <vector>
+
+#include "base/base_paths.h"
+#include "base/files/file_path.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "content/browser/media/cdm_service_impl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+
+const char kTestPath[] = "/aa/bb";
+const char kVersion1[] = "1.1.1.1";
+const char kVersion2[] = "1.1.1.2";
+const char kTestCodecs[] = "webm,mp4";

[xhwang, 2016/04/13 00:22:12]

nit: webm is not a codec

[jrummell, 2016/04/14 01:32:16]

Done.

+const char kCodecDelimiter[] = ",";
+
+// For simplicity and to make failures easier to diagnose, this test uses
+// std::string instead of base::FilePath and std::vector<std::string>.
+class CdmServiceImplTest : public testing::Test {
+ public:
+  CdmServiceImplTest() {}
+  ~CdmServiceImplTest() override {}
+
+ protected:
+  void Register(const std::string& type,
+                const std::string& version,
+                const std::string& path,
+                const std::string& supported_codecs) {
+    std::vector<std::string> codecs =
+        base::SplitString(supported_codecs, kCodecDelimiter,
+                          base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
+    CdmService::GetInstance()->RegisterCdm(
+        CdmInfo(type, base::Version(version),
+                base::FilePath::FromUTF8Unsafe(path), codecs));
+  }
+
+  bool IsRegistered(const std::string& type, const std::string& version) {
+    for (const auto& cdm : CdmService::GetInstance()->GetAllRegisteredCdms()) {
+      if (cdm.type == type && cdm.version.GetString() == version)
+        return true;
+    }
+    return false;
+  }
+};
+
+// Note that KeySystemService is a singleton, and thus the actions of
+// one test impact other tests. So each test defines a different key system
+// name to avoid conflicts.
+
+TEST_F(CdmServiceImplTest, Register) {
+  const char kTestKeySystem[] = "test1";

[xhwang, 2016/04/13 00:22:12]

kTestKeySystemType?

Also it seems not interesting to have different types for each test. Shall we
just use a const one for all tests?

[jrummell, 2016/04/14 01:32:16]

Renamed.
CdmService is a singleton, so the tests all add to the list. Using different
names avoids this.

[xhwang, 2016/04/14 06:20:26]

See the new comment about singleton.

+  Register(kTestKeySystem, kVersion1, kTestPath, kTestCodecs);
+  EXPECT_TRUE(IsRegistered(kTestKeySystem, kVersion1));
+}
+
+TEST_F(CdmServiceImplTest, ReRegister) {
+  const char kTestKeySystem[] = "test2";
+  Register(kTestKeySystem, kVersion1, "/bb/cc", "unknown");
+  EXPECT_TRUE(IsRegistered(kTestKeySystem, kVersion1));
+
+  // Now register same key system with different values.
+  Register(kTestKeySystem, kVersion1, kTestPath, kTestCodecs);
+  EXPECT_TRUE(IsRegistered(kTestKeySystem, kVersion1));
+}
+
+TEST_F(CdmServiceImplTest, MultipleVersions) {
+  const char kTestKeySystem[] = "test3";
+  Register(kTestKeySystem, kVersion1, kTestPath, kTestCodecs);
+  Register(kTestKeySystem, kVersion2, "/bb/cc", "unknown");
+  EXPECT_TRUE(IsRegistered(kTestKeySystem, kVersion1));
+  EXPECT_TRUE(IsRegistered(kTestKeySystem, kVersion2));
+}

[xhwang, 2016/04/13 00:22:12]

Can you add a test to make sure the new CDM is inserted from the beginning?

[jrummell, 2016/04/14 01:32:16]

Done.

+
+}  // namespace content