Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16366009: Use a direct include of strings headers in ppapi/, printing/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use a direct include of strings headers in ppapi/, printing/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205664

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : wrap comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/browser_font_resource_trusted.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_var_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/dictionary_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/private/net_address_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/var.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/test_case.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/enter.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/backend/print_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_cups.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/win_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_dialog_gtk_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/printed_pages_source.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16366009/1
7 years, 6 months ago (2013-06-10 21:53:10 UTC) #1
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8203
7 years, 6 months ago (2013-06-11 05:46:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16366009/7001
7 years, 6 months ago (2013-06-11 15:06:15 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8321
7 years, 6 months ago (2013-06-11 15:17:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16366009/7001
7 years, 6 months ago (2013-06-11 15:21:57 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on chromium_presubmit HTTP Error 400: Bad Request
7 years, 6 months ago (2013-06-11 15:28:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16366009/15001
7 years, 6 months ago (2013-06-11 15:29:20 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 17:07:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16366009/15001
7 years, 6 months ago (2013-06-11 17:36:42 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 22:52:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 205664

Powered by Google App Engine
This is Rietveld 408576698