Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 16366008: Add the option to bypass watchlists. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
Reviewers:
bradn, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Add the option to bypass watchlists. I have a large rename change and it's impossible to upload because the size of the CC field is above the maximum 2000 characters in Reitveld. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=205323

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M git_cl.py View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
7 years, 6 months ago (2013-06-10 21:52:10 UTC) #1
M-A Ruel
Why not upload with --bypass-hooks? Then you can run presubmit checks locally (to double-check) with ...
7 years, 6 months ago (2013-06-10 21:53:43 UTC) #2
bradn
LGTM
7 years, 6 months ago (2013-06-10 21:53:53 UTC) #3
brettw
maruel: because bypass-hooks doesn't skip the watchlists (please see the patch).
7 years, 6 months ago (2013-06-10 22:02:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/16366008/2001
7 years, 6 months ago (2013-06-10 22:03:00 UTC) #5
M-A Ruel
On 2013/06/10 22:02:44, brettw wrote: > maruel: because bypass-hooks doesn't skip the watchlists (please see ...
7 years, 6 months ago (2013-06-10 22:04:20 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 22:04:51 UTC) #7
Message was sent while issue was closed.
Change committed as 205323

Powered by Google App Engine
This is Rietveld 408576698