Issue 16365009: Remove dead code in CSSValuePool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16365009: Remove dead code in CSSValuePool. (Closed)

Created:
7 years, 6 months ago by darktears

Modified:
7 years, 6 months ago

Reviewers:
Julien - ping for review

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove dead code in CSSValuePool. drain() is unused. Its purpose was to clear the various caches in CSSValuePool. So far it's not used anywhere so we should remove dead code. In the future if we want to add cache clearing when memory is low we can just re-add this method. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151852

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -18 lines)			Patch
	M	Source/core/css/CSSValuePool.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/css/CSSValuePool.cpp	View		1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/16365009/1

7 years, 6 months ago (2013-06-05 16:05:50 UTC) #3

Message was sent while issue was closed.

Change committed as 151852

Expand Messages | Collapse Messages