Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 16365004: Don't force representations in the loop builder. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Don't force representations in the loop builder. Additionally, infer None-typed CompareIDAndBranch to Smi+actual input. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14960

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +1 line, -8 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-05 11:09:49 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-05 15:25:59 UTC) #2
Jakob Kummerow
On 2013/06/05 15:25:59, Jakob wrote: > lgtm ...and to document our offline discussion: Usually, Simulates ...
7 years, 6 months ago (2013-06-05 15:32:19 UTC) #3
Toon Verwaest
7 years, 6 months ago (2013-06-05 17:24:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14960 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698