Issue 16361009: Do not allow Views new-dialog-style windows to be resized.

Issue 16361009: Do not allow Views new-dialog-style windows to be resized. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not allow Views new-dialog-style windows to be resized. Continuation of https://codereview.chromium.org/15894025/ Allow the top-left to show the system menu on left-click. Allow the titlebar to show the system menu on right-click. Allow dragging dialogs from the titlebar (for now). Expand BubbleFrameViewTest.NonClientHitTest and support. Add dialog_delegate_unittest.cc and DialogTest.HitTest. Remove unnecessary CreateApplicationShortcutView overrides. BUG=166075, 244559, 244676, 246777 TEST=Views new-dialog-style windows cannot be resized, but do show the system menu and allow dragging (for now). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204190

Patch Set 1 #

Patch Set 2 : Do not allow new dialogs to be resized. #

Patch Set 3 : Remove unnecessary CreateApplicationShortcutView overrides. #

Patch Set 4 : Make DialogTest.HitTest more flexible. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -66 lines)			Patch
M	chrome/browser/ui/views/create_application_shortcut_view.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/create_application_shortcut_view.cc	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view.cc	View	1	1 chunk	+12 lines, -8 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view_unittest.cc	View		3 chunks	+42 lines, -48 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/views/window/dialog_delegate_unittest.cc	View	1 2 3	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16361009/10001

7 years, 6 months ago (2013-06-04 23:43:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16361009/20001

7 years, 6 months ago (2013-06-04 23:53:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16361009/20001

7 years, 6 months ago (2013-06-05 05:20:35 UTC) #5

mtomasz

7 years, 6 months ago (2013-06-19 06:50:06 UTC) #7

Message was sent while issue was closed.

On 2013/06/05 07:31:55, I haz the power (commit-bot) wrote:
> Change committed as 204190

I'm very surprised that resizing got disabled. I think we want the save-as and
open dialog to be resizeable.
There is a lot of content inside.

Expand Messages | Collapse Messages