Android: allows using adb from a chromium checkout without envsetup.sh

Android: allows using adb from a chromium checkout without envsetup.sh

Following comments on https://chromiumcodereview.appspot.com/15891002,
rather than setting the path in pylib.__init__, set it via constants and android_commands.py.
Note that android_commands calls into third_party/android_testrunner, which then
uses adb directly, so it still needs to tweak os.environ.path.

BUG=242960
TEST=./build/android/run_tests.py -s cc_perftests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204341

[bulach, 2013-06-04 09:16:59]

follow up from comments on https://chromiumcodereview.appspot.com/15891002 ,
ptal.

[Isaac (away), 2013-06-04 09:58:46]

lgtm, thanks for adjusting this, Marcus.

[Isaac (away), 2013-06-04 10:01:45]

one comment; if it's needed still lgtm.

https://chromiumcodereview.appspot.com/16360003/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/16360003/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:212: if adb_dir and adb_dir not in
os.environ['PATH']:
maybe 'adb_dir not in os.environ['PATH'].split(os.pathsep)' ?

https://chromiumcodereview.appspot.com/16360003/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:213: os.environ['PATH'] += os.pathsep +
adb_dir
is this needed?  What other binaries are needed from path variable?

[bulach, 2013-06-04 10:20:45]

thanks isaac! addressed, ptal

https://codereview.chromium.org/16360003/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/16360003/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:212: if adb_dir and adb_dir not in
os.environ['PATH']:
On 2013/06/04 10:01:45, Isaac wrote:
> maybe 'adb_dir not in os.environ['PATH'].split(os.pathsep)' ?

Done.

https://codereview.chromium.org/16360003/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:213: os.environ['PATH'] += os.pathsep +
adb_dir
On 2013/06/04 10:01:45, Isaac wrote:
> is this needed?  What other binaries are needed from path variable?

it's needed for third_party/android_testrunner that calls directly 'adb'. added
a comment to clarify.

[frankf, 2013-06-04 19:50:47]

https://codereview.chromium.org/16360003/diff/7/build/android/pylib/constants.py
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/16360003/diff/7/build/android/pylib/constants...
build/android/pylib/constants.py:87: def GetADBPath():
modules are imported once in python. Can't you just run this inline and get
constants.FULLY_QUILIFIED_ADB directly?

[bulach, 2013-06-05 08:18:27]

thanks frank! ptal

https://codereview.chromium.org/16360003/diff/7/build/android/pylib/constants.py
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/16360003/diff/7/build/android/pylib/constants...
build/android/pylib/constants.py:87: def GetADBPath():
On 2013/06/04 19:50:47, frankf wrote:
> modules are imported once in python. Can't you just run this inline and get
> constants.FULLY_QUILIFIED_ADB directly?

good idea! inverted here, so the function is internal and the constant is the
only thing exposed.

[frankf, 2013-06-05 17:40:39]

lgtm

[commit-bot: I haz the power, 2013-06-05 17:47:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/16360003/8001

[commit-bot: I haz the power, 2013-06-05 21:16:22]

Change committed as 204341