Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16358024: Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, stevenjb+watch_chromium.org, sail+watch_chromium.org, tim (not reviewing), oshima+watch_chromium.org, Raghu Simha, haitaol1, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -87 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/financial_ping.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/lib/financial_ping_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/lib/lib_values.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/machine_id.h View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/machine_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/rlz_lib.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/mac/lib/machine_id_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/win/lib/machine_id_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/rlz_value_store_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/app_container.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/app_container_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_closer.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_closer_agent.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_closer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_policy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_table.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/process_mitigations_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/process_policy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/wow_helper/wow_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/google_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/image_operations_bench.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/image_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sql/meta_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/statement.h View 1 chunk +1 line, -1 line 0 comments Download
M sql/statement.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/apply_control_data_updates_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/apply_updates_and_resolve_conflicts_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/build_commit_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/net/server_connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/process_commit_response_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_proto_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/syncer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/engine/syncer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/base_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/change_record.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_mutation_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/js_sync_manager_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/invalidation.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/unique_position.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/unique_position_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/change_record_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/write_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/sync_system_resources.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_backing_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/entry_kernel.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/write_transaction_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/accounts_client/test_accounts_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/test/engine/test_directory_setter_upper.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/test_id_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/local_sync_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/testserver/run_sync_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/cryptographer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/get_session_name_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/nigori.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/nigori_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16358024/1
7 years, 6 months ago (2013-06-10 22:11:58 UTC) #1
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests, content_unittests, nacl_integration, sql_unittests, sync_integration_tests, unit_tests ...
7 years, 6 months ago (2013-06-11 02:38:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16358024/1
7 years, 6 months ago (2013-06-11 03:36:51 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 07:28:20 UTC) #4
Message was sent while issue was closed. 
Change committed as 205458

Powered by Google App Engine
This is Rietveld 408576698