Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16358021: Use a direct include of strings headers in content/p*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, sail+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in content/p*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205764

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M content/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/access_token_store.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/child_process_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_id.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/download_item.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/javascript_dialog_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/plugin_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/speech_recognition_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_drag_dest_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_ui_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_ui_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_ui_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/worker_service_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/context_menu_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/file_chooser_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/speech_recognition_result.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/window_container_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/plugin/content_plugin_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_widget_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16358021/1
7 years, 6 months ago (2013-06-10 21:02:51 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 06:09:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16358021/26001
7 years, 6 months ago (2013-06-11 14:59:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=17183
7 years, 6 months ago (2013-06-12 00:35:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16358021/47001
7 years, 6 months ago (2013-06-12 00:39:43 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 13:52:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 205764

Powered by Google App Engine
This is Rietveld 408576698