chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java - Issue 1635753002: Introduce Queue-Based Notification Snackbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

Issue 1635753002: Introduce Queue-Based Notification Snackbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add VisibleForTesting to a method Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

index ab85ceb1a0c5b6b8569071788317ea4ebc3a3d8c..039ab6ef92fe1728b8f0ea3ca259c501d1cc6b42 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

@@ -95,10 +95,9 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle

String buttonText = mContext

.getString(isPreview ? R.string.data_reduction_lo_fi_preview_snackbar_action

: R.string.data_reduction_lo_fi_snackbar_action);

- mSnackbarManager.showSnackbar(Snackbar.make(message, this)

+ mSnackbarManager.showSnackbar(Snackbar.make(message, this, Snackbar.TYPE_NOTIFICATION)

.setAction(buttonText, tab.getId())

- .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS)

- .setForceDisplay());

+ .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));

DataReductionProxySettings.getInstance().incrementLoFiSnackbarShown();

DataReductionProxyUma.dataReductionProxyLoFiUIAction(

DataReductionProxyUma.ACTION_LOAD_IMAGES_SNACKBAR_SHOWN);