chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java - Issue 1635753002: Introduce Queue-Based Notification Snackbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

Issue 1635753002: Introduce Queue-Based Notification Snackbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add VisibleForTesting to a method Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

index 6776fcf4d11e7cbba987809d6f8a7b1b61870965..8dbc3c2a74c6b48b4dc334a653e123085f09caab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

@@ -119,9 +119,9 @@ public class EnhancedBookmarkUtils {

bookmarkModel, activity, bookmarkId);

if (getLastUsedParent(activity) == null) {

snackbar = Snackbar.make(activity.getString(R.string.enhanced_bookmark_page_saved),

- snackbarController);

+ snackbarController, Snackbar.TYPE_ACTION);

} else {

- snackbar = Snackbar.make(folderName, snackbarController)

+ snackbar = Snackbar.make(folderName, snackbarController, Snackbar.TYPE_ACTION)

.setTemplateText(activity.getString(

R.string.enhanced_bookmark_page_saved_folder));

}

@@ -164,7 +164,9 @@ public class EnhancedBookmarkUtils {

snackbarController = createSnackbarControllerForEditButton(

bookmarkModel, activity, bookmarkId);

}

- snackbar = Snackbar.make(activity.getString(messageId, suffix), snackbarController)

+ snackbar = Snackbar

+ .make(activity.getString(messageId, suffix), snackbarController,

+ Snackbar.TYPE_ACTION)

.setAction(activity.getString(buttonId), null).setSingleLine(false);

}