chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java - Issue 1635753002: Introduce Queue-Based Notification Snackbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 1635753002: Introduce Queue-Based Notification Snackbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add VisibleForTesting to a method Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

index d8d4049c7f3d429454d2ddecccb9e64b27ecf7c3..f13c97eccdc8925b72e6cc8c1c5836e0819cd9da 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

@@ -52,8 +52,9 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr

public void onDownloadSucceeded(

DownloadInfo downloadInfo, final long downloadId, boolean canBeResolved) {

if (getSnackbarManager() == null) return;

- Snackbar snackbar = Snackbar.make(mContext.getString(

- R.string.download_succeeded_message, downloadInfo.getFileName()), this);

+ Snackbar snackbar = Snackbar.make(

+ mContext.getString(R.string.download_succeeded_message, downloadInfo.getFileName()),

+ this, Snackbar.TYPE_NOTIFICATION);

// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.

snackbar.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS).setSingleLine(false);

Pair<DownloadInfo, Long> actionData = null;

@@ -75,7 +76,7 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr

public void onDownloadFailed(String errorMessage, boolean showAllDownloads) {

if (getSnackbarManager() == null) return;

// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.

- Snackbar snackbar = Snackbar.make(errorMessage, this)

+ Snackbar snackbar = Snackbar.make(errorMessage, this, Snackbar.TYPE_NOTIFICATION)

.setSingleLine(false)

.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS);

if (showAllDownloads) {