Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: media/cast/audio_sender/audio_encoder.cc

Issue 163553006: Cast: Refactoring Cast API's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updates and rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/audio_sender/audio_encoder.cc
diff --git a/media/cast/audio_sender/audio_encoder.cc b/media/cast/audio_sender/audio_encoder.cc
index 2363619750d6d462c428946cc13b9d28a2c27802..efe7a018c01d27c73bcd1e4fe7a1ca2057d951f0 100644
--- a/media/cast/audio_sender/audio_encoder.cc
+++ b/media/cast/audio_sender/audio_encoder.cc
@@ -52,16 +52,16 @@ class AudioEncoder::ImplBase : public base::SupportsWeakPtr<ImplBase> {
sampling_rate % 100 != 0 ||
samples_per_10ms_ * num_channels_ >
transport::EncodedAudioFrame::kMaxNumberOfSamples) {
- initialization_status_ = STATUS_INVALID_AUDIO_CONFIGURATION;
+ cast_initialization_cb_ = STATUS_INVALID_AUDIO_CONFIGURATION;
} else {
- initialization_status_ = STATUS_INITIALIZED;
+ cast_initialization_cb_ = STATUS_AUDIO_INITIALIZED;
}
}
virtual ~ImplBase() {}
CastInitializationStatus InitializationResult() const {
- return initialization_status_;
+ return cast_initialization_cb_;
}
void LogAudioFrameEvent(uint32 rtp_timestamp,
@@ -156,7 +156,7 @@ class AudioEncoder::ImplBase : public base::SupportsWeakPtr<ImplBase> {
const int num_channels_;
const int samples_per_10ms_;
const FrameEncodedCallback callback_;
- CastInitializationStatus initialization_status_;
+ CastInitializationStatus cast_initialization_cb_;
private:
// In the case where a call to EncodeAudio() cannot completely fill the
@@ -192,7 +192,7 @@ class AudioEncoder::OpusImpl : public AudioEncoder::ImplBase {
encoder_memory_(new uint8[opus_encoder_get_size(num_channels)]),
opus_encoder_(reinterpret_cast<OpusEncoder*>(encoder_memory_.get())),
buffer_(new float[num_channels * samples_per_10ms_]) {
- if (ImplBase::initialization_status_ != STATUS_INITIALIZED) {
+ if (ImplBase::cast_initialization_cb_ != STATUS_AUDIO_INITIALIZED) {
return;
}
@@ -316,7 +316,6 @@ AudioEncoder::AudioEncoder(
// Note: It doesn't matter which thread constructs AudioEncoder, just so long
// as all calls to InsertAudio() are by the same thread.
insert_thread_checker_.DetachFromThread();
-
switch (audio_config.codec) {
case transport::kOpus:
impl_.reset(new OpusImpl(cast_environment,
@@ -340,6 +339,7 @@ AudioEncoder::AudioEncoder(
AudioEncoder::~AudioEncoder() {}
CastInitializationStatus AudioEncoder::InitializationResult() const {
+ DCHECK(insert_thread_checker_.CalledOnValidThread());
if (impl_) {
return impl_->InitializationResult();
}

Powered by Google App Engine
This is Rietveld 408576698