Cast: Refactoring Cast API's

media/cast/cast_sender_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_CAST_CAST_SENDER_IMPL_H_
 #define MEDIA_CAST_CAST_SENDER_IMPL_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "media/cast/audio_sender/audio_sender.h"
 #include "media/cast/cast_config.h"
+#include "media/cast/cast_defines.h"
 #include "media/cast/cast_environment.h"
 #include "media/cast/cast_sender.h"
 #include "media/cast/video_sender/video_sender.h"
 
 namespace media {
 class VideoFrame;
-}
 
-namespace media {
 namespace cast {
-
 class AudioSender;
 class VideoSender;
 
-// This calls is a pure owner class that group all required sending objects
-// together such as pacer, packet receiver, frame input, audio and video sender.
+// This class combines all required sending objects such as the audio and video
+// senders, pacer, packet receiver and frame input.
 class CastSenderImpl : public CastSender {
  public:
-  CastSenderImpl(
-      scoped_refptr<CastEnvironment> cast_environment,
-      const AudioSenderConfig* audio_config,
-      const VideoSenderConfig* video_config,
-      const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories,
-      const CastInitializationCallback& initialization_status,
-      transport::CastTransportSender* const transport_sender);
+  CastSenderImpl(scoped_refptr<CastEnvironment> cast_environment,
+                 const CastInitializationCallback& cast_initialization_cb,
+                 transport::CastTransportSender* const transport_sender);
+
+  virtual void InitializeAudio(const AudioSenderConfig& audio_config) OVERRIDE;
+  virtual void InitializeVideo(
+      const VideoSenderConfig& video_config,
+      const scoped_refptr<GpuVideoAcceleratorFactories>& gpu_factories)
+      OVERRIDE;
 
   virtual ~CastSenderImpl();
 
   virtual scoped_refptr<FrameInput> frame_input() OVERRIDE;
   virtual transport::PacketReceiverCallback packet_receiver() OVERRIDE;
 
  private:
   void ReceivedPacket(scoped_ptr<Packet> packet);
-  // Used to trampoline the result back on the correct thread. And guaranteed
-  // not to be called until the creation is complete.
+  // Used to trampoline the result back on the correct thread. Guaranteed
+  // to be called only after creation is complete.
   void InitializationResult(CastInitializationStatus status) const;
 
   CastInitializationCallback initialization_callback_;
   scoped_ptr<AudioSender> audio_sender_;
   scoped_ptr<VideoSender> video_sender_;
   scoped_refptr<FrameInput> frame_input_;
   transport::PacketReceiverCallback packet_receiver_;
   scoped_refptr<CastEnvironment> cast_environment_;
+  transport::CastTransportSender* const
+      transport_sender_;  // Not owned by this class.

[Ami GONE FROM CHROMIUM, 2014/02/14 18:23:54]

I was hoping for a positive statement about who _does_ own this.  Because that's
basically a requirement that that owner outlive this class.

[mikhal1, 2014/02/18 19:20:43]

Done.

   uint32 ssrc_of_audio_sender_;
   uint32 ssrc_of_video_sender_;
   base::WeakPtrFactory<CastSenderImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastSenderImpl);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_CAST_SENDER_IMPL_H_