Issue 16354006: Fix a bug in quic_in_memory_cache.

Issue 16354006: Fix a bug in quic_in_memory_cache. (Closed)

Created:
7 years, 6 months ago by honghaiz

Modified:
7 years, 6 months ago

Reviewers:
ramant (doing other things), Ryan Hamilton, honghaiz1

CC:
chromium-reviews, cbentzel+watch_chromium.org, Matt Welsh

Base URL:
https://chromium.googlesource.com/chromium/src.git@quic_clientserver2

Visibility:
Public.

More Reviews

Description

Fix a bug in quic_in_memory_cache. When adding response to the cache, it removes "http://", but when getting response from the cache, it does not. As a result, no content is fetched out from the cache even for urls in the cache. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207807

Patch Set 1 #

Patch Set 2 : Add unittest. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -0 lines)			Patch
A	net/data/quic_in_memory_cache_data/quic-datatesturl.com/,	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	net/net.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/quic_in_memory_cache.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
A	net/tools/quic/quic_in_memory_cache_test.cc	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

This change should first be made in the internal repo. and then merged over. I'll ...

7 years, 6 months ago (2013-06-12 18:44:34 UTC) #2

honghaiz1

Ping for review. On Tue, Jun 18, 2013 at 12:51 PM, <honghaiz@chromium.org> wrote: > Added ...

7 years, 6 months ago (2013-06-20 16:30:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/honghaiz@chromium.org/16354006/7001

7 years, 6 months ago (2013-06-20 20:12:52 UTC) #6

Message was sent while issue was closed.

Change committed as 207807

Expand Messages | Collapse Messages