Issue 16351002: Fix problems when renaming and entering a directory fast in Files.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16351002: Fix problems when renaming and entering a directory fast in Files.app. (Closed)

Created:
7 years, 6 months ago by mtomasz

Modified:
7 years, 6 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix problems when renaming and entering a directory fast in Files.app. Renaming on Drive takes significant amount of time. Renaming and immediately entering a directory, caused later staying in a directory which no more exists. This patch resolves this issue by changing to the new directory from the old one, once the renaming operation is finished. TEST=Create a directory, enter some different name, double hit ENTER. Try to create a directory again. Should not fail. BUG=227456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203961

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -3 lines)			Patch
M	chrome/browser/resources/file_manager/js/directory_model.js	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/sidebar.js	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/16351002/1

7 years, 6 months ago (2013-06-04 05:39:02 UTC) #3

Message was sent while issue was closed.

Change committed as 203961

Expand Messages | Collapse Messages