Issue 16344003: [Autofill] Fix popup delegate to show warnings correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16344003: [Autofill] Fix popup delegate to show warnings correctly. (Closed)

Created:
7 years, 6 months ago by Ilya Sherman

Modified:
7 years, 6 months ago

Reviewers:
csharp

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Fix popup delegate to show warnings correctly. BUG=247880 TEST=out/Debug/unit_tests --gtest_filter=AutofillExternalDelegateUnitTest.AutofillWarnings R=csharp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205502

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
	M	components/autofill/browser/autofill_external_delegate.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
	M	components/autofill/browser/autofill_external_delegate_unittest.cc	View		2 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/16344003/1

7 years, 6 months ago (2013-06-10 22:49:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160961

7 years, 6 months ago (2013-06-11 06:03:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/16344003/1

7 years, 6 months ago (2013-06-11 06:18:45 UTC) #5

Message was sent while issue was closed.

Change committed as 205502

Expand Messages | Collapse Messages