Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 16337010: Remove IDBCursorBackendInterface::deleteFunction (part 2/3) (Closed)

Created:
7 years, 6 months ago by jsbell
Modified:
7 years, 6 months ago
Reviewers:
Tom Sepez, alecflett
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Remove IDBCursorBackendInterface::deleteFunction (part 2/3) Remove IPC plumbing (and new backend impl) now that the front-end of IDBCursor just relies on IDBDatabaseBackendInterface::deleteRange() BUG=241526 R=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203770

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -276 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 3 chunks +2 lines, -16 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor_impl.h View 4 chunks +5 lines, -12 lines 1 comment Download
M content/browser/indexed_db/indexed_db_cursor_impl.cc View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/indexed_db/webidbcursor_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/webidbcursor_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common_child/indexed_db/indexed_db_dispatcher.h View 6 chunks +68 lines, -87 lines 2 comments Download
M content/common_child/indexed_db/indexed_db_dispatcher.cc View 24 chunks +77 lines, -97 lines 2 comments Download
M content/common_child/indexed_db/proxy_webidbcursor_impl.h View 1 chunk +4 lines, -7 lines 0 comments Download
M content/common_child/indexed_db/proxy_webidbcursor_impl.cc View 6 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jsbell
alecflett@ - please take a look? I ran clang-format over the touched files so there ...
7 years, 6 months ago (2013-06-03 17:52:27 UTC) #1
alecflett
lgtm
7 years, 6 months ago (2013-06-03 18:39:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/16337010/1
7 years, 6 months ago (2013-06-03 18:42:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6435
7 years, 6 months ago (2013-06-03 18:48:06 UTC) #4
jsbell
tsepez@ - can you review the IPC change? (deleting message)
7 years, 6 months ago (2013-06-03 18:55:38 UTC) #5
Tom Sepez
On 2013/06/03 18:55:38, jsbell wrote: > tsepez@ - can you review the IPC change? (deleting ...
7 years, 6 months ago (2013-06-03 19:02:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/16337010/1
7 years, 6 months ago (2013-06-03 19:27:50 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 21:08:06 UTC) #8
Message was sent while issue was closed.
Change committed as 203770

Powered by Google App Engine
This is Rietveld 408576698