Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16337002: Revert "Revert "Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT"" (Closed)

Created:
7 years, 6 months ago by brunoabinader
Modified:
7 years, 6 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, leviw+renderwatch, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Revert "Implement CSS3TextDecorations runtime flag in favor of CSS3_TEXT"" This reverts commit 8db58082becfc73002a9f3f923ab48328550523d with some rebased changes. The original patch was reverted after running into issue 241495, which seems fixed now. BUG=239225 TBR=junov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151849

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+871 lines, -621 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js View 2 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js View 2 chunks +32 lines, -32 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-style.js View 2 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html View 2 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-color.html View 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-line.html View 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-line-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-style.html View 1 chunk +8 lines, -8 lines 0 comments Download
A LayoutTests/platform/chromium-linux/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt View 1 chunk +102 lines, -0 lines 0 comments Download
A LayoutTests/platform/chromium-linux/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt View 1 chunk +93 lines, -0 lines 0 comments Download
A LayoutTests/platform/chromium-linux/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt View 1 chunk +96 lines, -0 lines 0 comments Download
M LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt View 1 chunk +68 lines, -68 lines 0 comments Download
M LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt View 1 chunk +63 lines, -63 lines 0 comments Download
M LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt View 1 chunk +64 lines, -64 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt View 1 chunk +68 lines, -68 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt View 1 chunk +63 lines, -63 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt View 1 chunk +64 lines, -64 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 4 chunks +7 lines, -10 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 5 chunks +20 lines, -18 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 4 chunks +3 lines, -5 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/GraphicsContext.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/platform/graphics/GraphicsTypes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 8 chunks +3 lines, -18 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 6 chunks +3 lines, -11 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 5 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brunoabinader
Junov, this is the rebased/updated patch from the one from issue 15876005, could you please ...
7 years, 6 months ago (2013-06-04 23:37:43 UTC) #1
Julien - ping for review
Forwarding junov's LGTM
7 years, 6 months ago (2013-06-05 15:19:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brunoabinader@gmail.com/16337002/4001
7 years, 6 months ago (2013-06-05 15:29:44 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 16:47:15 UTC) #4
Message was sent while issue was closed. 
Change committed as 151849

Powered by Google App Engine
This is Rietveld 408576698