Enable high dpi in win/views.

Enable high dpi in win/views.

BUG=149881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205831

[girard, 2013-06-05 20:14:33]

Enables high dpi support in Windows non-aura build, when ENABLE_HIDPI is
#defined.

[kevers, 2013-06-06 13:32:33]

https://codereview.chromium.org/16336027/diff/4001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/16336027/diff/4001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.cc:832: return
frame_->GetRestoredBounds();
whitespace change?

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.cc
File ui/gfx/rect_conversions.cc (right):

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.cc...
ui/gfx/rect_conversions.cc:16: Rect ToSizedRect(const RectF& rect) {
See comment for header file change.

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.h
File ui/gfx/rect_conversions.h (right):

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.h#...
ui/gfx/rect_conversions.h:15: 
Don't think this method is used anywhere in the patch.  I seem to recall that it
was present in an earlier proof-of-concept patch to partially address potential
mismatches when scaling rects versus size objects.  Unless I missed a reference
in this CL, this should probably be pulled out for the time being.

https://codereview.chromium.org/16336027/diff/4001/ui/views/win/hwnd_message_...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/16336027/diff/4001/ui/views/win/hwnd_message_...
ui/views/win/hwnd_message_handler.cc:1165: double scale =
ui::win::GetDeviceScaleFactor();
Is this fix for both Aura and non-Aura?

[girard, 2013-06-10 14:27:56]

Cleaned up the code as per Kevin's review.

https://codereview.chromium.org/16336027/diff/4001/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/16336027/diff/4001/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_view.cc:832: return
frame_->GetRestoredBounds();
On 2013/06/06 13:32:33, kevers wrote:
> whitespace change?

No idea. I've reverted this.

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.cc
File ui/gfx/rect_conversions.cc (right):

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.cc...
ui/gfx/rect_conversions.cc:16: Rect ToSizedRect(const RectF& rect) {
On 2013/06/06 13:32:33, kevers wrote:
> See comment for header file change.

Done (reverted).

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.h
File ui/gfx/rect_conversions.h (right):

https://codereview.chromium.org/16336027/diff/4001/ui/gfx/rect_conversions.h#...
ui/gfx/rect_conversions.h:15: 
On 2013/06/06 13:32:33, kevers wrote:
> Don't think this method is used anywhere in the patch.  I seem to recall that
it
> was present in an earlier proof-of-concept patch to partially address
potential
> mismatches when scaling rects versus size objects.  Unless I missed a
reference
> in this CL, this should probably be pulled out for the time being.

Agreed. It's gone.

https://codereview.chromium.org/16336027/diff/4001/ui/views/win/hwnd_message_...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/16336027/diff/4001/ui/views/win/hwnd_message_...
ui/views/win/hwnd_message_handler.cc:1165: double scale =
ui::win::GetDeviceScaleFactor();
On 2013/06/06 13:32:33, kevers wrote:
> Is this fix for both Aura and non-Aura?

It's been tested under aura and non-aura.

[kevers, 2013-06-10 15:51:49]

lgtm.  Will need OWNER approval.

[Ben Goodger (Google), 2013-06-11 16:10:43]

https://codereview.chromium.org/16336027/diff/11001/ui/views/controls/native/...
File ui/views/controls/native/native_view_host.cc (right):

https://codereview.chromium.org/16336027/diff/11001/ui/views/controls/native/...
ui/views/controls/native/native_view_host.cc:107: #if defined(OS_WIN) &&
!defined(USE_AURA)
this file doesn't really have platform stuff in it - that's the point of the
native wrapper. can you move this stuff into there?

[girard, 2013-06-11 19:12:13]

Moved logic as suggested.

https://codereview.chromium.org/16336027/diff/11001/ui/views/controls/native/...
File ui/views/controls/native/native_view_host.cc (right):

https://codereview.chromium.org/16336027/diff/11001/ui/views/controls/native/...
ui/views/controls/native/native_view_host.cc:107: #if defined(OS_WIN) &&
!defined(USE_AURA)
On 2013/06/11 16:10:43, Ben Goodger (Google) wrote:
> this file doesn't really have platform stuff in it - that's the point of the
> native wrapper. can you move this stuff into there?

Done. Thanks.

[Ben Goodger (Google), 2013-06-11 20:11:14]

lgtm

[commit-bot: I haz the power, 2013-06-11 20:35:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/16336027/17001

[commit-bot: I haz the power, 2013-06-12 04:26:26]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-12 14:09:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/16336027/51001

[commit-bot: I haz the power, 2013-06-12 17:00:15]

Change committed as 205831