InstantExtended: Workaround Blink bug 68841.

InstantExtended: Workaround Blink bug 68841.

BUG=246229
TEST=Manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203903

[Jered, 2013-06-03 20:27:20]

Please review.

This seems to workaround the bug but finding it is going to be an awful dig
through Blink code...

[samarth, 2013-06-03 21:14:57]

lgtm

This looks fine but one question:
If you do keep clicking on a most-visited tile and hitting "back", does the
total number of iframes on the page keep growing? If yes, wouldn't we be better
off garbage-collecting the old ones? <iframe>s aren't that cheap.

Thanks,
Samarth

[Jered, 2013-06-03 21:25:01]

On 2013/06/03 21:14:57, samarth wrote:
> lgtm
> 
> This looks fine but one question:
> If you do keep clicking on a most-visited tile and hitting "back", does the
> total number of iframes on the page keep growing? If yes, wouldn't we be
better
> off garbage-collecting the old ones? <iframe>s aren't that cheap.
> 
> Thanks,
> Samarth

The total number of iframes on the page is constant. What the garbage
collector is doing is anyone's guess, did you have specific ideas?

[samarth, 2013-06-03 21:27:13]

On 2013/06/03 21:25:01, Jered wrote:
> The total number of iframes on the page is constant.

That's really all I care about.  From this morning's discussions, it wasn't
clear to me whether this was the case or not.

Thanks,
Samarth

[Jered, 2013-06-03 21:35:29]

On 2013/06/03 21:27:13, samarth wrote:
> On 2013/06/03 21:25:01, Jered wrote:
> > The total number of iframes on the page is constant.
> 
> That's really all I care about.  From this morning's discussions, it wasn't
> clear to me whether this was the case or not.
> 
> Thanks,
> Samarth

I do notice that as I sit and reload the NTP, the "Memory" column for
the Instant process in the Task Manager grows. But if record in the
"Timeline" view, the memory use plot spikes and then drops again.
I suspect the latter shows RSS and the former shows VM size, but I'm
not an expert in how Chrome reports these things. Probably we should
take a closer look but I think it's independent of this.

Jered

[commit-bot: I haz the power, 2013-06-03 21:38:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jered@chromium.org/16336020/1

[commit-bot: I haz the power, 2013-06-04 07:46:48]

Change committed as 203903