Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 16336004: create simple skia app for android using jni (Closed)

Created:
7 years, 6 months ago by Zach Reizner
Modified:
7 years, 6 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

create simple skia app for android using jni Committed: http://code.google.com/p/skia/source/detail?r=9437

Patch Set 1 #

Total comments: 32

Patch Set 2 : fancier graphics #

Total comments: 5

Patch Set 3 : text draw and modify Android.mk #

Patch Set 4 : move HelloSkia and resync with master #

Patch Set 5 : move to platform_tools/android/examples #

Patch Set 6 : remove binary files #

Messages

Total messages: 21 (0 generated)
Zach Reizner
7 years, 6 months ago (2013-06-03 15:09:37 UTC) #1
djsollen
move this code into platform_tools/android/ndk_demo_app. Also don't include the libskia_android.so in the CL, but rather ...
7 years, 6 months ago (2013-06-03 18:24:45 UTC) #2
Zach Reizner
SkAutoGraphics causes a SkAssert to fail when used too many times, so it was removed ...
7 years, 6 months ago (2013-06-03 22:54:25 UTC) #3
djsollen
It is getting pretty close. I would add a README file to this directory that ...
7 years, 6 months ago (2013-06-04 00:26:34 UTC) #4
Zach Reizner
In the README I reference the Android quick start guide in the online documentation to ...
7 years, 6 months ago (2013-06-04 14:35:45 UTC) #5
djsollen
the code looks good to me. The only thing that needs to be done is ...
7 years, 6 months ago (2013-06-04 19:08:29 UTC) #6
Zach Reizner
On 2013/06/04 19:08:29, djsollen wrote: > the code looks good to me. The only thing ...
7 years, 6 months ago (2013-06-04 19:21:23 UTC) #7
djsollen
how about we create a new folder called examples/ and put it in there under ...
7 years, 6 months ago (2013-06-04 19:30:29 UTC) #8
Zach Reizner
7 years, 6 months ago (2013-06-04 19:40:40 UTC) #9
djsollen
this on is my fault, sorry. I intended it to be platform_tools/android/examples.
7 years, 6 months ago (2013-06-04 20:17:20 UTC) #10
Zach Reizner
7 years, 6 months ago (2013-06-04 20:48:27 UTC) #11
djsollen
lgtm
7 years, 6 months ago (2013-06-04 20:50:21 UTC) #12
djsollen
now that you have an lgtm you can click the commit button and it should ...
7 years, 6 months ago (2013-06-04 20:50:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zachr@google.com/16336004/32001
7 years, 6 months ago (2013-06-04 20:54:15 UTC) #14
commit-bot: I haz the power
Can't process patch for file platform_tools/android/examples/hello_skia_app/res/drawable-hdpi/ic_launcher.png. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-06-04 20:54:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zachr@google.com/16336004/32001
7 years, 6 months ago (2013-06-04 20:54:37 UTC) #16
commit-bot: I haz the power
Can't process patch for file platform_tools/android/examples/hello_skia_app/res/drawable-hdpi/ic_launcher.png. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-06-04 20:54:42 UTC) #17
Zach Reizner
7 years, 6 months ago (2013-06-04 21:04:11 UTC) #18
djsollen
lgtm with the removed images. I'll upload them in the morning.
7 years, 6 months ago (2013-06-04 21:05:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zachr@google.com/16336004/36002
7 years, 6 months ago (2013-06-04 21:06:16 UTC) #20
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 21:13:33 UTC) #21
Message was sent while issue was closed.
Change committed as 9437

Powered by Google App Engine
This is Rietveld 408576698