Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 16331011: Move string files in base/ to the string subdirectory. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Move string files in base/ to the string subdirectory. BUG=247723 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205050

Patch Set 1 #

Patch Set 2 : more forwarding headers #

Patch Set 3 : fix forwarding #

Patch Set 4 : untrusted? #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -3732 lines) Patch
M base/base.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M base/base.gypi View 3 chunks +10 lines, -10 lines 0 comments Download
M base/base_untrusted.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/string16.h View 1 chunk +4 lines, -186 lines 0 comments Download
D base/string16.cc View 1 2 3 4 1 chunk +0 lines, -82 lines 0 comments Download
D base/string16_unittest.cc View 1 2 3 4 1 chunk +0 lines, -53 lines 0 comments Download
M base/string_util.h View 1 chunk +4 lines, -573 lines 0 comments Download
D base/string_util.cc View 1 2 3 4 1 chunk +0 lines, -1012 lines 0 comments Download
D base/string_util_constants.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D base/string_util_posix.h View 1 2 1 chunk +4 lines, -50 lines 0 comments Download
D base/string_util_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1190 lines 0 comments Download
D base/string_util_win.h View 1 2 1 chunk +4 lines, -58 lines 0 comments Download
M base/stringprintf.h View 1 chunk +4 lines, -59 lines 0 comments Download
D base/stringprintf.cc View 1 2 3 4 1 chunk +0 lines, -186 lines 0 comments Download
D base/stringprintf_unittest.cc View 1 chunk +0 lines, -187 lines 0 comments Download
A + base/strings/string16.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/strings/string16.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + base/strings/string16_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A + base/strings/string_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/strings/string_util.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
A + base/strings/string_util_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/strings/string_util_posix.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + base/strings/string_util_unittest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
A + base/strings/string_util_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + base/strings/stringprintf.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/strings/stringprintf.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + base/strings/stringprintf_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-06-07 18:38:08 UTC) #1
Ben Goodger (Google)
You should get a base owner for this.
7 years, 6 months ago (2013-06-07 20:08:50 UTC) #2
Avi (use Gerrit)
7 years, 6 months ago (2013-06-07 20:11:20 UTC) #3
brettw
LGTM. The reason I hadn't moved these is that I was using the existance of ...
7 years, 6 months ago (2013-06-07 20:30:24 UTC) #4
Avi (use Gerrit)
On 2013/06/07 20:30:24, brettw wrote: > LGTM. The reason I hadn't moved these is that ...
7 years, 6 months ago (2013-06-07 20:33:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16331011/10001
7 years, 6 months ago (2013-06-07 20:33:29 UTC) #6
commit-bot: I haz the power
Failed to apply patch for base/strings/string16_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; A base/strings/string16_unittest.cc ...
7 years, 6 months ago (2013-06-07 20:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16331011/20001
7 years, 6 months ago (2013-06-07 20:38:54 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-08 06:05:48 UTC) #9
Message was sent while issue was closed.
Change committed as 205050

Powered by Google App Engine
This is Rietveld 408576698