Web MIDI: implement MIDISuccessCallback and MIDIOptions

Web MIDI: implement MIDISuccessCallback and MIDIOptions

This change implements MIDISuccessCallback and MIDIOptions.
Since the IDL generator can not handle Dictionary as an arugment of
handleEvent in callback interface, MIDIOptions is not used for now.

BUG=163795
TEST=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151961

[Takashi Toyoshima, 2013-06-03 13:47:43]

Hi Chris,
Can you take a look this?

[Chris Rogers, 2013-06-04 04:43:57]

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIOptions.h (right):

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIOptions.h:42: options.get("susexEnabled",
sysexEnabled);
typo: "susexEnabled" -> "sysexEnabled"

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDISuccessCallback.h (right):

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDISuccessCallback.h:34: #include
"modules/webmidi/MIDIOptions.h"
why does "MIDIOptions.h" need to be included here?

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDISuccessCallback.h:49: void
scheduleCallback(ScriptExecutionContext*);
I don't understand why this callback needs to have this scheduleCallback()
method.  Why don't we just use a simple callback like:
https://codereview.chromium.org/16288002/diff/2001/Source/modules/webmidi/MID...
https://codereview.chromium.org/16288002/diff/2001/Source/modules/webmidi/MID...

[Takashi Toyoshima, 2013-06-04 05:35:37]

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIOptions.h (right):

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIOptions.h:42: options.get("susexEnabled",
sysexEnabled);
On 2013/06/04 04:43:57, Chris Rogers wrote:
> typo: "susexEnabled" -> "sysexEnabled"

Done.

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDISuccessCallback.h (right):

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDISuccessCallback.h:34: #include
"modules/webmidi/MIDIOptions.h"
Once IDL generator bug is fixed and the second argument of handleEvent() is
changed to Dictionary, this line is needed to include "bindings/v8/Dictionary.h"
indirectly.
This manner follows FileSystem API's FileSystemFlags.

https://codereview.chromium.org/16331005/diff/2001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDISuccessCallback.h:49: void
scheduleCallback(ScriptExecutionContext*);
Originally this is needed to post a callback tasks correctly in various places
and timings in the old API spec.
But, now these callback handlings will be hidden by Future. It's fine to remove
this and the same one of MIDIErrorCallback.

[Takashi Toyoshima, 2013-06-06 12:21:55]

Chris, can you take another look?

[Chris Rogers, 2013-06-06 17:13:47]

lgtm

[commit-bot: I haz the power, 2013-06-06 17:44:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/16331005/13001

[commit-bot: I haz the power, 2013-06-06 20:37:33]

Change committed as 151961