Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16325022: move content/common_child to content/child (Closed)

Created:
7 years, 6 months ago by scottmg
Modified:
7 years, 6 months ago
Reviewers:
palmer, jamesr, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Rename content/common_child to content/child As prerequiste for linked bug. TBR=palmer@chromium.org R=jam@chromium.org,jamesr@chromium.org BUG=246357 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203945

Patch Set 1 #

Total comments: 2

Patch Set 2 : content_common_child.gypi -> content_chid.gypi #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -5787 lines) Patch
M content/browser/renderer_host/java/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/fileapi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/fileapi/webfilesystem_callback_adapters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/fileapi/webfilesystem_callback_adapters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/child/fileapi/webfilesystem_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/fileapi/webfilesystem_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/child/fileapi/webfilewriter_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/fileapi/webfilewriter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/indexed_db/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/indexed_db_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/indexed_db/indexed_db_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/indexed_db_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbcursor_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbcursor_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbcursor_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbdatabase_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbdatabase_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbfactory_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/indexed_db/proxy_webidbfactory_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/np_channel_base.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/child/np_channel_base.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/npobject_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/npobject_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/child/npobject_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/child/npobject_stub.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/child/npobject_stub.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/child/npobject_util.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/child/npobject_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/child/plugin_message_generator.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/plugin_message_generator.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
A + content/child/plugin_messages.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/plugin_param_traits.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/plugin_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/web_database_observer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/web_database_observer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/child/webblobregistry_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/child/webblobregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/common/java_bridge_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D content/common_child/fileapi/OWNERS View 1 chunk +0 lines, -14 lines 0 comments Download
D content/common_child/fileapi/webfilesystem_callback_adapters.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/common_child/fileapi/webfilesystem_callback_adapters.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D content/common_child/fileapi/webfilesystem_impl.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/common_child/fileapi/webfilesystem_impl.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D content/common_child/fileapi/webfilewriter_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/common_child/fileapi/webfilewriter_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D content/common_child/indexed_db/OWNERS View 1 chunk +0 lines, -15 lines 0 comments Download
D content/common_child/indexed_db/indexed_db_dispatcher.h View 1 chunk +0 lines, -241 lines 0 comments Download
D content/common_child/indexed_db/indexed_db_dispatcher.cc View 1 chunk +0 lines, -713 lines 0 comments Download
D content/common_child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/common_child/indexed_db/indexed_db_message_filter.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/common_child/indexed_db/indexed_db_message_filter.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbcursor_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbcursor_impl.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbcursor_impl_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbdatabase_impl.h View 1 chunk +0 lines, -103 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbdatabase_impl.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbfactory_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/common_child/indexed_db/proxy_webidbfactory_impl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/common_child/np_channel_base.h View 1 chunk +0 lines, -203 lines 0 comments Download
D content/common_child/np_channel_base.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D content/common_child/npobject_base.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/common_child/npobject_proxy.h View 1 chunk +0 lines, -127 lines 0 comments Download
D content/common_child/npobject_proxy.cc View 1 chunk +0 lines, -507 lines 0 comments Download
D content/common_child/npobject_stub.h View 1 chunk +0 lines, -99 lines 0 comments Download
D content/common_child/npobject_stub.cc View 1 chunk +0 lines, -424 lines 0 comments Download
D content/common_child/npobject_util.h View 1 chunk +0 lines, -74 lines 0 comments Download
D content/common_child/npobject_util.cc View 1 chunk +0 lines, -292 lines 0 comments Download
D content/common_child/plugin_message_generator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D content/common_child/plugin_message_generator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/common_child/plugin_messages.h View 1 chunk +0 lines, -380 lines 0 comments Download
D content/common_child/plugin_param_traits.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/common_child/plugin_param_traits.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D content/common_child/web_database_observer_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/common_child/web_database_observer_impl.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D content/common_child/webblobregistry_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/common_child/webblobregistry_impl.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M content/content.gyp View 1 8 chunks +9 lines, -9 lines 0 comments Download
A content/content_child.gypi View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
M content/content_common_child.gypi View 1 1 chunk +0 lines, -70 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/plugin_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/plugin_channel_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/worker/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/websharedworkerclient_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/worker/worker_thread.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/git/move_source_file.py View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
(anyone else who will want to kibitz on this change I should add?)
7 years, 6 months ago (2013-06-04 00:37:32 UTC) #1
jam
lgtm https://codereview.chromium.org/16325022/diff/1/content/content_common_child.gypi File content/content_common_child.gypi (right): https://codereview.chromium.org/16325022/diff/1/content/content_common_child.gypi#newcode1 content/content_common_child.gypi:1: # Copyright (c) 2012 The Chromium Authors. All ...
7 years, 6 months ago (2013-06-04 01:03:12 UTC) #2
scottmg
tbr palmer for content/common/java_bridge_messages.h (just renamed a header it includes) https://codereview.chromium.org/16325022/diff/1/content/content_common_child.gypi File content/content_common_child.gypi (right): https://codereview.chromium.org/16325022/diff/1/content/content_common_child.gypi#newcode1 ...
7 years, 6 months ago (2013-06-04 03:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/16325022/8001
7 years, 6 months ago (2013-06-04 03:36:50 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-04 03:52:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/16325022/8001
7 years, 6 months ago (2013-06-04 03:53:33 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 12:56:03 UTC) #7
Message was sent while issue was closed. 
Change committed as 203945

Powered by Google App Engine
This is Rietveld 408576698