Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 16325016: Roll FFMpeg DEPS to pick up .gyp change. (Closed)

Created:
7 years, 6 months ago by DaleCurtis
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Roll FFMpeg DEPS to pick up .gyp change. Pulls in: 245a8c0 Fix gyp to include c_sources for non-Windows platforms 9407fc5 Add experimental support for building ffmpeg with clang on Windows BUG=none TEST=passes trybots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203831

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update DEPS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
DaleCurtis
7 years, 6 months ago (2013-06-03 20:10:56 UTC) #1
Reid Kleckner
LGTM, the hash looks right. :) https://codereview.chromium.org/16325016/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/16325016/diff/1/DEPS#newcode28 DEPS:28: "ffmpeg_revision": "203759", Curious: ...
7 years, 6 months ago (2013-06-03 20:13:37 UTC) #2
DaleCurtis
Nope, ffmpeg svn is part of normal chromium svn, so the revision number is not ...
7 years, 6 months ago (2013-06-03 20:16:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/16325016/1
7 years, 6 months ago (2013-06-03 20:16:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests, content_browsertests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=121180
7 years, 6 months ago (2013-06-03 20:26:23 UTC) #5
Reid Kleckner (google)
Looks like a real failure: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/121173/steps/media_unittests/logs/stdio [9719:9719:0603/132438:1114736262519:FATAL:media.cc(74)] Check failed: g_media_library.Get().Initialize(module_dir). I'll see what happens on ...
7 years, 6 months ago (2013-06-03 20:31:07 UTC) #6
Reid Kleckner (google)
Yeah, c_sources wasn't getting in there on Linux. :( Fix: https://gerrit.chromium.org/gerrit/#/c/57369/ On Mon, Jun 3, ...
7 years, 6 months ago (2013-06-03 21:04:34 UTC) #7
DaleCurtis
Rerolled. CQ'ing.
7 years, 6 months ago (2013-06-03 22:32:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/16325016/8002
7 years, 6 months ago (2013-06-03 22:33:35 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=57414
7 years, 6 months ago (2013-06-03 22:55:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/16325016/8002
7 years, 6 months ago (2013-06-04 00:28:43 UTC) #11
commit-bot: I haz the power
Change committed as 203831
7 years, 6 months ago (2013-06-04 03:51:07 UTC) #12
Reid Kleckner (google)
7 years, 6 months ago (2013-06-04 12:14:55 UTC) #13
Awesome!  Thanks for the help!


On Mon, Jun 3, 2013 at 11:51 PM, <commit-bot@chromium.org> wrote:

> Change committed as 203831
>
>
https://chromiumcodereview.**appspot.com/16325016/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698