Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 16324002: Expose net::LoadTimingInfo through content_shell (Closed)

Created:
7 years, 6 months ago by Pan
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, mmenke
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Expose net::LoadTimingInfo through content_shell Since blink use content_shell to run layout test, we need to expose net::LoadTimingInfo through content_shell Contributed by pan.deng@intel.com BUG=246117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203959

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Pan
Hi James, I noticed blink switched to content_shell to run layout tests, without this change, ...
7 years, 6 months ago (2013-06-03 09:31:38 UTC) #1
James Simonsen
You should remove the other callers in chrome_resource_dispatcher_host_delegate.cc, otherwise we end up doing this multiple ...
7 years, 6 months ago (2013-06-03 23:34:14 UTC) #2
Pan
removed duplicate GetLoadTiming, thanks :) Pan https://codereview.chromium.org/16324002/diff/1/content/browser/loader/resource_loader.cc File content/browser/loader/resource_loader.cc (right): https://codereview.chromium.org/16324002/diff/1/content/browser/loader/resource_loader.cc#newcode58 content/browser/loader/resource_loader.cc:58: request->GetLoadTimingInfo(&(response->head.load_timing)); On 2013/06/03 ...
7 years, 6 months ago (2013-06-04 00:51:49 UTC) #3
James Simonsen
lgtm You'll need to track down a chrome/ owner now too though.
7 years, 6 months ago (2013-06-04 00:54:59 UTC) #4
Pan
Hi, @jochen, @darin, @jam could you please help review this patch :) thanks! Pan
7 years, 6 months ago (2013-06-04 01:06:46 UTC) #5
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-04 05:21:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/16324002/7001
7 years, 6 months ago (2013-06-04 06:06:43 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 13:51:22 UTC) #8
Message was sent while issue was closed.
Change committed as 203959

Powered by Google App Engine
This is Rietveld 408576698