Issue 16321002: Rewrite DownloadHandlerTest using DummyFileSystem.

Issue 16321002: Rewrite DownloadHandlerTest using DummyFileSystem. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rewrite DownloadHandlerTest using DummyFileSystem. BUG=246098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203941

Patch Set 2 : Comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -238 lines)			Patch
M	chrome/browser/chromeos/drive/download_handler_unittest.cc	View	1	10 chunks	+77 lines, -96 lines	0 comments	Download
D	chrome/browser/chromeos/drive/mock_file_system.h	View	1	1 chunk	+0 lines, -125 lines	0 comments	Download
D	chrome/browser/chromeos/drive/mock_file_system.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hashimoto

lgtm https://codereview.chromium.org/16321002/diff/1/chrome/browser/chromeos/drive/download_handler_unittest.cc File chrome/browser/chromeos/drive/download_handler_unittest.cc (right): https://codereview.chromium.org/16321002/diff/1/chrome/browser/chromeos/drive/download_handler_unittest.cc#newcode35 chrome/browser/chromeos/drive/download_handler_unittest.cc:35: // Test file system to nit: "Test file ...

7 years, 6 months ago (2013-06-04 00:53:09 UTC) #2

kinaba

https://codereview.chromium.org/16321002/diff/1/chrome/browser/chromeos/drive/download_handler_unittest.cc File chrome/browser/chromeos/drive/download_handler_unittest.cc (right): https://codereview.chromium.org/16321002/diff/1/chrome/browser/chromeos/drive/download_handler_unittest.cc#newcode35 chrome/browser/chromeos/drive/download_handler_unittest.cc:35: // Test file system to On 2013/06/04 00:53:09, hashimoto ...

7 years, 6 months ago (2013-06-04 03:46:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16321002/7001

7 years, 6 months ago (2013-06-04 03:46:41 UTC) #4

Message was sent while issue was closed.

Change committed as 203941

Expand Messages | Collapse Messages