Issue 16320010: Use a direct include of strings headers in chrome/app/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16320010: Use a direct include of strings headers in chrome/app/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a direct include of strings headers in chrome/app/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205256

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -18 lines)			Patch
M	chrome/app/breakpad_field_trial_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/breakpad_field_trial_win.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/breakpad_unittest_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/breakpad_win.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/app/chrome_main_delegate.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/app/client_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/client_util.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/app/delay_load_hook_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/hard_error_handler_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320010/1

7 years, 6 months ago (2013-06-10 14:58:38 UTC) #1

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=136400

7 years, 6 months ago (2013-06-10 16:59:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320010/1

7 years, 6 months ago (2013-06-10 17:13:03 UTC) #3

Message was sent while issue was closed.

Change committed as 205256

Expand Messages | Collapse Messages