Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: base/version.cc

Issue 16320009: Use a direct include of strings headers in base/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/values_unittest.cc ('k') | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_util.h"
11 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_split.h" 11 #include "base/strings/string_split.h"
12 #include "base/strings/string_util.h"
13 13
14 namespace base { 14 namespace base {
15 15
16 namespace { 16 namespace {
17 17
18 // Parses the |numbers| vector representing the different numbers 18 // Parses the |numbers| vector representing the different numbers
19 // inside the version string and constructs a vector of valid integers. It stops 19 // inside the version string and constructs a vector of valid integers. It stops
20 // when it reaches an invalid item (including the wildcard character). |parsed| 20 // when it reaches an invalid item (including the wildcard character). |parsed|
21 // is the resulting integer vector. Function returns true if all numbers were 21 // is the resulting integer vector. Function returns true if all numbers were
22 // parsed successfully, false otherwise. 22 // parsed successfully, false otherwise.
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 size_t count = components_.size(); 167 size_t count = components_.size();
168 for (size_t i = 0; i < count - 1; ++i) { 168 for (size_t i = 0; i < count - 1; ++i) {
169 version_str.append(IntToString(components_[i])); 169 version_str.append(IntToString(components_[i]));
170 version_str.append("."); 170 version_str.append(".");
171 } 171 }
172 version_str.append(IntToString(components_[count - 1])); 172 version_str.append(IntToString(components_[count - 1]));
173 return version_str; 173 return version_str;
174 } 174 }
175 175
176 } // namespace base 176 } // namespace base
OLDNEW
« no previous file with comments | « base/values_unittest.cc ('k') | base/win/event_trace_consumer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698