Issue 16313003: ARM: Fix build flags for snapshot generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16313003: ARM: Fix build flags for snapshot generation. (Closed)

Created:
7 years, 6 months ago by ulan

Modified:
7 years, 6 months ago

Reviewers:
Rodolph Perfetta, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

ARM: Fix build flags for snapshot generation. The existing code ignores armv7 and arm_fpu flags since r14288. R=jkummerow@chromium.org, rodolph.perfetta@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=14998

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -51 lines)			Patch
	M	build/common.gypi	View	1	3 chunks	+128 lines, -51 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

PTAL. Jakob, this is the snippet that you sent me with minor fixes.

7 years, 6 months ago (2013-06-07 08:40:24 UTC) #1

ulan

7 years, 6 months ago (2013-06-07 10:02:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14998 (presubmit successful).