Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/extensions/updater/extension_updater.h

Issue 1630903003: Remove not needed ExtensionUpdater::default_params_ and its setter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_
6 #define CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 112
113 // Starts an update check right now, instead of waiting for the next 113 // Starts an update check right now, instead of waiting for the next
114 // regularly scheduled check or a pending check from CheckSoon(). 114 // regularly scheduled check or a pending check from CheckSoon().
115 void CheckNow(const CheckParams& params); 115 void CheckNow(const CheckParams& params);
116 116
117 // Returns true iff CheckSoon() has been called but the update check 117 // Returns true iff CheckSoon() has been called but the update check
118 // hasn't been performed yet. This is used mostly by tests; calling 118 // hasn't been performed yet. This is used mostly by tests; calling
119 // code should just call CheckSoon(). 119 // code should just call CheckSoon().
120 bool WillCheckSoon() const; 120 bool WillCheckSoon() const;
121 121
122 // Changes the params that are used for the automatic periodic update checks,
123 // as well as for explicit calls to CheckSoon.
124 void set_default_check_params(const CheckParams& params) {
125 default_params_ = params;
asargent_no_longer_on_chrome 2016/01/25 23:11:16 Can we also kill the default_params_ variable itse
lazyboy 2016/01/25 23:46:58 Even better, thanks. Done.
126 }
127
128 // Overrides the extension cache with |extension_cache| for testing. 122 // Overrides the extension cache with |extension_cache| for testing.
129 void SetExtensionCacheForTesting(ExtensionCache* extension_cache); 123 void SetExtensionCacheForTesting(ExtensionCache* extension_cache);
130 124
131 // Stop the timer to prevent scheduled updates for testing. 125 // Stop the timer to prevent scheduled updates for testing.
132 void StopTimerForTesting(); 126 void StopTimerForTesting();
133 127
134 private: 128 private:
135 friend class ExtensionUpdaterTest; 129 friend class ExtensionUpdaterTest;
136 friend class ExtensionUpdaterFileHandler; 130 friend class ExtensionUpdaterFileHandler;
137 131
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 std::map<std::string, ThrottleInfo> throttle_info_; 274 std::map<std::string, ThrottleInfo> throttle_info_;
281 275
282 base::WeakPtrFactory<ExtensionUpdater> weak_ptr_factory_; 276 base::WeakPtrFactory<ExtensionUpdater> weak_ptr_factory_;
283 277
284 DISALLOW_COPY_AND_ASSIGN(ExtensionUpdater); 278 DISALLOW_COPY_AND_ASSIGN(ExtensionUpdater);
285 }; 279 };
286 280
287 } // namespace extensions 281 } // namespace extensions
288 282
289 #endif // CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_ 283 #endif // CHROME_BROWSER_EXTENSIONS_UPDATER_EXTENSION_UPDATER_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698