Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: net/disk_cache/entry_unittest.cc

Issue 16306003: Fix uninitialized read in the SimpleCache tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/entry_unittest.cc
diff --git a/net/disk_cache/entry_unittest.cc b/net/disk_cache/entry_unittest.cc
index 4a2cf67c362eba989a94c7dc577b0241f93b7d99..659e49f511d2faba6860720d681108805d300c2e 100644
--- a/net/disk_cache/entry_unittest.cc
+++ b/net/disk_cache/entry_unittest.cc
@@ -2853,6 +2853,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheOptimisticWriteReleases) {
const int kWriteSize = 512;
scoped_refptr<net::IOBuffer> buffer1(new net::IOBuffer(kWriteSize));
EXPECT_TRUE(buffer1->HasOneRef());
+ CacheTestFillBuffer(buffer1->data(), kWriteSize, false);
// An optimistic write happens only when there is an empty queue of pending
// operations. To ensure the queue is empty, we issue a write and wait until
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698