Fix uninitialized read in the SimpleCache tests.

Fix uninitialized read in the SimpleCache tests.

DiskCacheEntryTest.SimpleCacheOptimisticWriteReleases did not initialize
its buffer. It was immaterial to the test, but less so to valgrind.

R=zhaoqin@chromium.org
BUG=245952
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203887

[gavinp, 2013-06-02 20:20:49]

qin: Please take a look.

[zhaoqin, 2013-06-02 20:32:57]

lgtm

[commit-bot: I haz the power, 2013-06-02 20:33:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[gavinp, 2013-06-02 21:29:12]

+pasko for lgtm

pasko, is your rubber stamp handy?

[pasko, 2013-06-03 08:54:34]

lgtm

[commit-bot: I haz the power, 2013-06-03 13:38:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/16306003/1

[commit-bot: I haz the power, 2013-06-03 13:38:43]

Failed to apply patch for tools/valgrind/memcheck/suppressions.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/valgrind/memcheck/suppressions.txt
  Hunk #1 FAILED at 7339.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/valgrind/memcheck/suppressions.txt.rej

Patch:       tools/valgrind/memcheck/suppressions.txt
Index: tools/valgrind/memcheck/suppressions.txt
diff --git a/tools/valgrind/memcheck/suppressions.txt
b/tools/valgrind/memcheck/suppressions.txt
index
463c2cfc655c89fded44c5a3e9288c1d4026c2f6..4f0718f5eb09a22e636fc6b8802b968d49e6fb4e
100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -7339,18 +7339,3 @@
fun:_ZN7content21RenderViewHostManager8NavigateERKNS_19NavigationEntryImplE
    fun:_ZN7content21ContentMainRunnerImpl3RunEv
    fun:_ZN7content11ContentMainEiPPKcPNS_19ContentMainDelegateE
 }
-{
-   bug_245952a
-   Memcheck:Uninitialized
-   fun:crc32_little
-   fun:MOZ_Z_crc32
-  
fun:_ZN10disk_cache15SimpleEntryImpl17WriteDataInternalEiiPN3net8IOBufferEiRKN4base8CallbackIFviEEEb
-}
-{
-   bug_245952b
-   Memcheck:Param
-   pwrite64(buf)
-   obj:/lib/x86_64-linux-gnu/libpthread-2.15.so
-   fun:_ZN4base17WritePlatformFileEilPKci
-   fun:_ZN10disk_cache22SimpleSynchronousEntry9WriteDataEiiPN3net8IOBufferEibPi
-}

[commit-bot: I haz the power, 2013-06-03 13:52:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/16306003/9001

[pasko, 2013-06-03 18:13:32]

now it needs a manual merge with:
http://src.chromium.org/viewvc/chrome?view=revision&revision=203621

after that I think committing manually would be best

[gavinp, 2013-06-03 18:15:25]

On 2013/06/03 18:13:32, pasko wrote:
> now it needs a manual merge with:
> http://src.chromium.org/viewvc/chrome?view=revision&revision=203621
> 
> after that I think committing manually would be best

The second upload is that manual merge. I believe this will land shortly once it
finishes CQ. I'll manually commit if it gets hung up any more though.

[zhaoqin, 2013-06-03 20:54:10]

On 2013/06/03 18:15:25, gavinp wrote:
> On 2013/06/03 18:13:32, pasko wrote:
> > now it needs a manual merge with:
> > http://src.chromium.org/viewvc/chrome?view=revision&revision=203621
> > 
> > after that I think committing manually would be best
> 
> The second upload is that manual merge. I believe this will land shortly once
it
> finishes CQ. I'll manually commit if it gets hung up any more though.

It is still not committed yet, is there something wrong with the CQ?

[gavinp, 2013-06-03 20:59:56]

On 2013/06/03 20:54:10, zhaoqin wrote:
> On 2013/06/03 18:15:25, gavinp wrote:
> > On 2013/06/03 18:13:32, pasko wrote:
> > > now it needs a manual merge with:
> > > http://src.chromium.org/viewvc/chrome?view=revision&revision=203621
> > > 
> > > after that I think committing manually would be best
> > 
> > The second upload is that manual merge. I believe this will land shortly
once
> it
> > finishes CQ. I'll manually commit if it gets hung up any more though.
> 
> It is still not committed yet, is there something wrong with the CQ?

Maruel advised me to uncheck CQ, wait, then check it again.

[commit-bot: I haz the power, 2013-06-03 21:03:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/16306003/9001

[commit-bot: I haz the power, 2013-06-04 07:07:38]

Change committed as 203887