Simplify mailbox handling in MailboxOutputSurface

Simplify mailbox handling in MailboxOutputSurface

With r202992 landed, We don't need to consume anymore before recycling, we only
need to produce once, and we don't need to unbind from FBOs before doing so.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203823

[no sievers, 2013-06-03 22:03:50]

lgtm, nice.

https://codereview.chromium.org/16305019/diff/1/content/renderer/gpu/mailbox_...
File content/renderer/gpu/mailbox_output_surface.cc (left):

https://codereview.chromium.org/16305019/diff/1/content/renderer/gpu/mailbox_...
content/renderer/gpu/mailbox_output_surface.cc:132: GL_FRAMEBUFFER,
GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, 0, 0);
This was necessary for some Android driver that had problems with incomplete
FBOs being bound (even if you did not access the framebuffer). Looks like the
currently bound FBO would just stay complete now though, right?

[commit-bot: I haz the power, 2013-06-03 22:23:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/16305019/1

[commit-bot: I haz the power, 2013-06-03 22:40:45]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-03 22:49:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/16305019/1

[commit-bot: I haz the power, 2013-06-03 23:00:25]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-03 23:05:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/16305019/1

[commit-bot: I haz the power, 2013-06-04 03:25:30]

Change committed as 203823

[no sievers, 2013-06-05 02:24:01]

Do we still need to insert a waitSyncPoint() to make sure we don't start
clobbering the texture, while the browser is still using it?
(Maybe in BindFramebuffer.)

[piman, 2013-06-05 07:42:07]

On Tue, Jun 4, 2013 at 7:24 PM, <sievers@chromium.org> wrote:

> Do we still need to insert a waitSyncPoint() to make sure we don't start
> clobbering the texture, while the browser is still using it?
> (Maybe in BindFramebuffer.)
>

I think I got overeager with deletions here. Feel free to revert if it's
blocking something, otherwise I'll fix it tomorrow.

Antoine


>
>
>
>
https://codereview.chromium.**org/16305019/<https://codereview.chromium.org/1...
>