Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: public/platform/WebRTCPeerConnectionHandler.h

Issue 16305017: Removes the old createDataChannel and starts to use the new one with WebRTCDataChannelInit (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebRTCDataChannelInit.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebRTCPeerConnectionHandler.h
diff --git a/public/platform/WebRTCPeerConnectionHandler.h b/public/platform/WebRTCPeerConnectionHandler.h
index fb2fc6f46faf29972fddd90d156dc1c8d532301f..7d9310e9d80b04f316b80cacb331acbd5c21ca9c 100644
--- a/public/platform/WebRTCPeerConnectionHandler.h
+++ b/public/platform/WebRTCPeerConnectionHandler.h
@@ -31,9 +31,6 @@
#ifndef WebRTCPeerConnectionHandler_h
#define WebRTCPeerConnectionHandler_h
-#include "WebCommon.h"
-#include "WebString.h"
-
namespace WebKit {
class WebMediaConstraints;
class WebMediaStream;
@@ -47,15 +44,8 @@ class WebRTCSessionDescription;
class WebRTCSessionDescriptionRequest;
class WebRTCStatsRequest;
class WebRTCVoidRequest;
-
-struct WebRTCDataChannelInit {
- unsigned short id;
- bool ordered;
- bool negotiated;
- int maxRetransmitTime;
- int maxRetransmits;
- WebString protocol;
-};
+class WebString;
+struct WebRTCDataChannelInit;
class WebRTCPeerConnectionHandler {
public:
@@ -74,12 +64,7 @@ public:
virtual bool addStream(const WebMediaStream&, const WebMediaConstraints&) = 0;
virtual void removeStream(const WebMediaStream&) = 0;
virtual void getStats(const WebRTCStatsRequest&) = 0;
- virtual WebRTCDataChannelHandler* createDataChannel(const WebString& label, bool reliable) = 0;
- virtual WebRTCDataChannelHandler* createDataChannel(const WebString& label, const WebRTCDataChannelInit& init)
- {
- WEBKIT_ASSERT_NOT_REACHED();
- return 0;
- }
+ virtual WebRTCDataChannelHandler* createDataChannel(const WebString& label, const WebRTCDataChannelInit&) = 0;
virtual WebRTCDTMFSenderHandler* createDTMFSender(const WebMediaStreamTrack&) = 0;
virtual void stop() = 0;
};
« no previous file with comments | « public/platform/WebRTCDataChannelInit.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698