src/effects/SkXfermodeImageFilter.cpp - Issue 16305016: Fix leak of effect in SkXfermodeImageFilter::filterImageGPU()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 16305016: Fix leak of effect in SkXfermodeImageFilter::filterImageGPU() (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 5f2d3689e8c6b338c2b6d800fd2bb0ffbf88b25c..a7f50c30cd08d0f17c7aba56ec70b707c4f5c9b7 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -102,7 +102,7 @@ bool SkXfermodeImageFilter::filterImageGPU(Proxy* proxy, const SkBitmap& src, Sk

if (NULL != xferEffect) {

paint.colorStage(0)->setEffect(

GrSimpleTextureEffect::Create(foregroundTex, GrEffect::MakeDivByTextureWHMatrix(foregroundTex)))->unref();

- paint.colorStage(1)->setEffect(xferEffect);

+ paint.colorStage(1)->setEffect(xferEffect)->unref();

context->drawRect(paint, srcRect);

} else {

paint.colorStage(0)->setEffect(

« no previous file with comments | « no previous file | no next file » | no next file with comments »