Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16305016: Fix leak of effect in SkXfermodeImageFilter::filterImageGPU() (Closed)

Created:
7 years, 6 months ago by bsalomon
Modified:
7 years, 6 months ago
Reviewers:
Stephen White
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix leak of effect in SkXfermodeImageFilter::filterImageGPU() Committed: http://code.google.com/p/skia/source/detail?r=9418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
I should of caught this before... the xferEffect gets leaked if it isn't null.
7 years, 6 months ago (2013-06-03 19:18:51 UTC) #1
Stephen White
Thanks! (mutter mutter need smart pointers mutter mutter)
7 years, 6 months ago (2013-06-03 19:20:31 UTC) #2
Stephen White
LGTM
7 years, 6 months ago (2013-06-03 19:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16305016/1
7 years, 6 months ago (2013-06-03 19:30:36 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 19:40:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 9418

Powered by Google App Engine
This is Rietveld 408576698