Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 16305012: [Android] Delaying previous selection check. (Closed)

Created:
7 years, 6 months ago by aurimas (slooooooooow)
Modified:
7 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] Delaying previous selection check. editable.replace(..) call has side-effects on selection therefore, we have to delay the previous selection check until after that. BUG=232426 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Ted, Could you take a look at this CL? Thanks! Aurimas
7 years, 6 months ago (2013-06-03 18:02:25 UTC) #1
Ted C
lgtm
7 years, 6 months ago (2013-06-03 18:11:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/16305012/1
7 years, 6 months ago (2013-06-03 18:20:55 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 18:21:02 UTC) #4
Message was sent while issue was closed.
Change committed as 203735

Powered by Google App Engine
This is Rietveld 408576698