chrome/browser/feedback/feedback_util.cc - Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/feedback_util.cc

Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/feedback/feedback_util.cc

diff --git a/chrome/browser/feedback/feedback_util.cc b/chrome/browser/feedback/feedback_util.cc

index 456d21fbfe66155c018fcdc2f1bf7fb7263177fa..319c91bd893ae6fd005fa6d3a659fde7a0c76843 100644

--- a/chrome/browser/feedback/feedback_util.cc

+++ b/chrome/browser/feedback/feedback_util.cc

@@ -240,7 +240,7 @@ bool FeedbackUtil::ValidFeedbackSize(const std::string& content) {

// static

void FeedbackUtil::SendReport(scoped_refptr<FeedbackData> data) {

- if (!data) {

+ if (!data.get()) {

LOG(ERROR) << "FeedbackUtil::SendReport called with NULL data!";

NOTREACHED();

return;

« no previous file with comments | « no previous file | chrome/browser/geolocation/access_token_store_browsertest.cc » ('j') | no next file with comments »