Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 16295015: Remove onUpdate from systemInfo.cpu API (Closed)

Created:
7 years, 6 months ago by Tim Song
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove onUpdate from systemInfo.cpu API BUG=237294 TEST=updated unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -687 lines) Patch
M chrome/browser/extensions/api/system_info/system_info_api.cc View 9 chunks +1 line, -33 lines 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h View 2 chunks +1 line, -60 lines 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc View 2 chunks +2 lines, -113 lines 0 comments Download
D chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_android.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_linux.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_mac.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_unittest.cc View 4 chunks +2 lines, -215 lines 0 comments Download
D chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_win.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc View 4 chunks +2 lines, -33 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/system_info_cpu.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/cpu/test_cpu_api.js View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tim Song
Hi Anthony. This is a follow up changelist to the systemInfo.cpu refactor. Please take a ...
7 years, 6 months ago (2013-06-03 18:21:58 UTC) #1
asargent_no_longer_on_chrome
lgtm
7 years, 6 months ago (2013-06-03 22:28:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16295015/1
7 years, 6 months ago (2013-06-03 22:57:13 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 04:20:41 UTC) #4
Message was sent while issue was closed.
Change committed as 203845

Powered by Google App Engine
This is Rietveld 408576698