Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5339)

Unified Diff: chrome/browser/extensions/convert_user_script_unittest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/browser/extensions/convert_web_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/convert_user_script_unittest.cc
diff --git a/chrome/browser/extensions/convert_user_script_unittest.cc b/chrome/browser/extensions/convert_user_script_unittest.cc
index 506b3cb16a310646008202478e90ba99c3d220c5..1e1fa3ad93339861f9b04cd8fff55899d64a8cd6 100644
--- a/chrome/browser/extensions/convert_user_script_unittest.cc
+++ b/chrome/browser/extensions/convert_user_script_unittest.cc
@@ -61,9 +61,9 @@ TEST_F(ExtensionFromUserScript, Basic) {
extension->public_key());
EXPECT_EQ(Manifest::TYPE_USER_SCRIPT, extension->GetType());
- ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension).size());
+ ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension.get()).size());
const UserScript& script =
- ContentScriptsInfo::GetContentScripts(extension)[0];
+ ContentScriptsInfo::GetContentScripts(extension.get())[0];
EXPECT_EQ(UserScript::DOCUMENT_IDLE, script.run_location());
ASSERT_EQ(2u, script.globs().size());
EXPECT_EQ("http://www.google.com/*", script.globs().at(0));
@@ -114,9 +114,9 @@ TEST_F(ExtensionFromUserScript, NoMetadata) {
extension->public_key());
EXPECT_EQ(Manifest::TYPE_USER_SCRIPT, extension->GetType());
- ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension).size());
+ ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension.get()).size());
const UserScript& script =
- ContentScriptsInfo::GetContentScripts(extension)[0];
+ ContentScriptsInfo::GetContentScripts(extension.get())[0];
ASSERT_EQ(1u, script.globs().size());
EXPECT_EQ("*", script.globs()[0]);
EXPECT_EQ(0u, script.exclude_globs().size());
@@ -181,9 +181,9 @@ TEST_F(ExtensionFromUserScript, RunAtDocumentStart) {
EXPECT_EQ(Manifest::TYPE_USER_SCRIPT, extension->GetType());
// Validate run location.
- ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension).size());
+ ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension.get()).size());
const UserScript& script =
- ContentScriptsInfo::GetContentScripts(extension)[0];
+ ContentScriptsInfo::GetContentScripts(extension.get())[0];
EXPECT_EQ(UserScript::DOCUMENT_START, script.run_location());
}
@@ -216,9 +216,9 @@ TEST_F(ExtensionFromUserScript, RunAtDocumentEnd) {
EXPECT_EQ(Manifest::TYPE_USER_SCRIPT, extension->GetType());
// Validate run location.
- ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension).size());
+ ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension.get()).size());
const UserScript& script =
- ContentScriptsInfo::GetContentScripts(extension)[0];
+ ContentScriptsInfo::GetContentScripts(extension.get())[0];
EXPECT_EQ(UserScript::DOCUMENT_END, script.run_location());
}
@@ -252,9 +252,9 @@ TEST_F(ExtensionFromUserScript, RunAtDocumentIdle) {
EXPECT_EQ(Manifest::TYPE_USER_SCRIPT, extension->GetType());
// Validate run location.
- ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension).size());
+ ASSERT_EQ(1u, ContentScriptsInfo::GetContentScripts(extension.get()).size());
const UserScript& script =
- ContentScriptsInfo::GetContentScripts(extension)[0];
+ ContentScriptsInfo::GetContentScripts(extension.get())[0];
EXPECT_EQ(UserScript::DOCUMENT_IDLE, script.run_location());
}
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/browser/extensions/convert_web_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698