chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

index 01777f9b4d017b3f4f02c6b0b25e8d37ceb3f406..5820af44ef2161664a2c083eb35a731badf2eb46 100644

--- a/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

@@ -52,7 +52,7 @@ void ExtensionWebRequestHelpersTestWithThreadsTest::SetUp() {

Extension::NO_FLAGS,

"ext_id_1",

&error);

- ASSERT_TRUE(permissionless_extension_) << error;

+ ASSERT_TRUE(permissionless_extension_.get()) << error;

com_extension_ =

LoadManifestUnchecked("permissions",

"web_request_com_host_permissions.json",

@@ -60,7 +60,7 @@ void ExtensionWebRequestHelpersTestWithThreadsTest::SetUp() {

Extension::NO_FLAGS,

"ext_id_2",

&error);

- ASSERT_TRUE(com_extension_) << error;

+ ASSERT_TRUE(com_extension_.get()) << error;

extension_info_map_ = new ExtensionInfoMap;

extension_info_map_->AddExtension(permissionless_extension_.get(),

base::Time::Now(),

@@ -149,25 +149,25 @@ TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest,

GURL("http://example.com"), NULL, &context, NULL);

EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL(

- extension_info_map_,

+ extension_info_map_.get(),

permissionless_extension_->id(),

request.url(),

false /*crosses_incognito*/,

WebRequestPermissions::DO_NOT_CHECK_HOST));

EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL(

- extension_info_map_,

+ extension_info_map_.get(),

permissionless_extension_->id(),

request.url(),

false /*crosses_incognito*/,

WebRequestPermissions::REQUIRE_HOST_PERMISSION));

EXPECT_TRUE(WebRequestPermissions::CanExtensionAccessURL(

- extension_info_map_,

+ extension_info_map_.get(),

com_extension_->id(),

request.url(),

false /*crosses_incognito*/,

WebRequestPermissions::REQUIRE_HOST_PERMISSION));

EXPECT_FALSE(WebRequestPermissions::CanExtensionAccessURL(

- extension_info_map_,

+ extension_info_map_.get(),

com_extension_->id(),

request.url(),

false /*crosses_incognito*/,