Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
index 21344860835de628e4ca98568fa660e4161125dd..1d0a7bb35282ed9e9bf3ea3b845b03639113a5a1 100644
--- a/chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
+++ b/chrome/browser/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
@@ -44,7 +44,7 @@ class StorageSchemaManifestHandlerTest : public testing::Test {
scoped_refptr<Extension> extension = Extension::Create(
temp_dir_.path(), Manifest::UNPACKED, manifest_,
Extension::NO_FLAGS, "", &error);
- if (!extension)
+ if (!extension.get())
return NULL;
base::FilePath schema_path = temp_dir_.path().AppendASCII("schema.json");
if (schema.empty()) {
@@ -60,7 +60,7 @@ class StorageSchemaManifestHandlerTest : public testing::Test {
testing::AssertionResult Validates(const std::string& schema) {
scoped_refptr<Extension> extension = CreateExtension(schema);
- if (!extension)
+ if (!extension.get())
return testing::AssertionFailure() << "Failed to create test extension";
std::string error;
std::vector<InstallWarning> warnings;
@@ -78,7 +78,7 @@ class StorageSchemaManifestHandlerTest : public testing::Test {
TEST_F(StorageSchemaManifestHandlerTest, Parse) {
scoped_refptr<Extension> extension = CreateExtension("");
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
// No storage.managed_schema entry.
string16 error;
@@ -87,12 +87,12 @@ TEST_F(StorageSchemaManifestHandlerTest, Parse) {
// Not a string.
manifest_.SetInteger("storage.managed_schema", 123);
extension = CreateExtension("");
- EXPECT_FALSE(extension);
+ EXPECT_FALSE(extension.get());
// All good now.
manifest_.SetString("storage.managed_schema", "schema.json");
extension = CreateExtension("");
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_TRUE(handler_->Parse(extension.get(), &error)) << error;
}

Powered by Google App Engine
This is Rietveld 408576698