chrome/browser/extensions/api/socket/socket_apitest.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/record/record_api_test.cc ('k') | chrome/browser/extensions/api/storage/settings_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/socket_apitest.cc

diff --git a/chrome/browser/extensions/api/socket/socket_apitest.cc b/chrome/browser/extensions/api/socket/socket_apitest.cc

index 27122366787cb7786930d4a8e790b3fe625943a9..bf3be559efc5083a103a001cd8973920f6972630 100644

--- a/chrome/browser/extensions/api/socket/socket_apitest.cc

+++ b/chrome/browser/extensions/api/socket/socket_apitest.cc

@@ -123,9 +123,7 @@ IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketUDPCreateGood) {

socket_create_function->set_has_callback(true);

scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(

- socket_create_function,

- "[\"udp\"]",

- browser(), utils::NONE));

+ socket_create_function.get(), "[\"udp\"]", browser(), utils::NONE));

ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());

DictionaryValue *value = static_cast<DictionaryValue*>(result.get());

int socketId = -1;

@@ -142,9 +140,7 @@ IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPCreateGood) {

socket_create_function->set_has_callback(true);

scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(

- socket_create_function,

- "[\"tcp\"]",

- browser(), utils::NONE));

+ socket_create_function.get(), "[\"tcp\"]", browser(), utils::NONE));

ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());

DictionaryValue *value = static_cast<DictionaryValue*>(result.get());

int socketId = -1;

@@ -161,7 +157,7 @@ IN_PROC_BROWSER_TEST_F(SocketApiTest, GetNetworkList) {

socket_function->set_has_callback(true);

scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(

- socket_function, "[]", browser(), utils::NONE));

+ socket_function.get(), "[]", browser(), utils::NONE));

ASSERT_EQ(base::Value::TYPE_LIST, result->GetType());

// If we're invoking socket tests, all we can confirm is that we have at