chrome/browser/extensions/api/notifications/notifications_api.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_message_process_host.cc ('k') | chrome/browser/extensions/api/notifications/notifications_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_api.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_api.cc b/chrome/browser/extensions/api/notifications/notifications_api.cc

index 597cc8a7772b7ac4b665aece8db866d9ab9e266f..3bacbadcacd6632c5afd96df7171cc13d63f01d3 100644

--- a/chrome/browser/extensions/api/notifications/notifications_api.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_api.cc

@@ -58,7 +58,7 @@ class NotificationsApiDelegate : public NotificationDelegate {

id_(id),

scoped_id_(CreateScopedIdentifier(extension_id, id)),

process_id_(-1) {

- DCHECK(api_function_);

+ DCHECK(api_function_.get());

if (api_function_->render_view_host())

process_id_ = api_function->render_view_host()->GetProcess()->GetID();

}

@@ -105,7 +105,7 @@ class NotificationsApiDelegate : public NotificationDelegate {

// until ReleaseRVH is called, and api_function_ (as a

// UIThreadExtensionFunction) will zero out its copy of render_view_host

// when the RVH goes away.

- if (!api_function_)

+ if (!api_function_.get())

return NULL;

return api_function_->render_view_host();

}