chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/extensions/api/identity/experimental_identity_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index b26b8c1a7b933d192691c29ba80e751f202e21ce..e8b2f099f532d432474d5600b582130c4b65360c 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -464,11 +464,11 @@ void ExtensionActionFunction::NotifyChange() {

switch (extension_action_->action_type()) {

case ActionInfo::TYPE_BROWSER:

case ActionInfo::TYPE_PAGE:

- if (ExtensionActionManager::Get(profile_)->

- GetBrowserAction(*extension_)) {

+ if (ExtensionActionManager::Get(profile_)

+ ->GetBrowserAction(*extension_.get())) {

NotifyBrowserActionChange();

- } else if (ExtensionActionManager::Get(profile_)->

- GetPageAction(*extension_)) {

+ } else if (ExtensionActionManager::Get(profile_)

+ ->GetPageAction(*extension_.get())) {

NotifyLocationBarChange();

}

return;