chrome/browser/extensions/api/declarative/declarative_api.cc - Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/declarative_api.cc

Issue 16295003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/declarative_api.cc

diff --git a/chrome/browser/extensions/api/declarative/declarative_api.cc b/chrome/browser/extensions/api/declarative/declarative_api.cc

index 2429658e6e4db9f6d1a24025e62db3f059316c0a..f0ec23e162e763572471422dc2a4911cc3105439 100644

--- a/chrome/browser/extensions/api/declarative/declarative_api.cc

+++ b/chrome/browser/extensions/api/declarative/declarative_api.cc

@@ -42,7 +42,7 @@ bool RulesFunction::RunImpl() {

rules_registry_ = rules_registry_service->GetRulesRegistry(event_name);

// Raw access to this function is not available to extensions, therefore

// there should never be a request for a nonexisting rules registry.

- EXTENSION_FUNCTION_VALIDATE(rules_registry_);

+ EXTENSION_FUNCTION_VALIDATE(rules_registry_.get());

if (content::BrowserThread::CurrentlyOn(rules_registry_->owner_thread())) {

bool success = RunImplOnCorrectThread();

@@ -52,7 +52,7 @@ bool RulesFunction::RunImpl() {

content::BrowserThread::GetMessageLoopProxyForThread(

rules_registry_->owner_thread());

base::PostTaskAndReplyWithResult(

- message_loop_proxy,

+ message_loop_proxy.get(),

FROM_HERE,

base::Bind(&RulesFunction::RunImplOnCorrectThread, this),

base::Bind(&RulesFunction::SendResponse, this));